Re: [PATCH v7] mm: cma: support sysfs

[Dmitry Osipenko]

25.03.2021 00:55, Minchan Kim пишет:
>>> +static ssize_t alloc_pages_success_show(struct kobject *kobj,
>>> +					struct kobj_attribute *attr, char *buf)
>>> +{
>>> +	struct cma *cma = cma_from_kobj(kobj);
>>> +
>>> +	return sysfs_emit(buf, "%llu\n",
>>> +			atomic64_read(&cma->nr_pages_succeeded));
>> nit: Algnment isn't right, should be better to write it as single line, IMO.
> Let me make it align rather than single line since I know someone
> who keep asking us to not overflow 80 columns unless it's special.
> 

I'm actually one of those guys who complains about 80 chars (where
necessary), but in this particular case it only hurts readability of the
code, IMO.