Re: [PATCH -next] x86/kprobes: Fix old-style-declaration warning

[Masami Hiramatsu]

On Wed, 24 Mar 2021 14:45:02 +0000
'Wei Yongjun <weiyongjun1@xxxxxxxxxx> wrote:

> From: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> 
> Gcc reports build warning as follows:
> 
> arch/x86/kernel/kprobes/core.c:940:1:
>  warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
>   940 | static int nokprobe_inline kprobe_is_ss(struct kprobe_ctlblk *kcb)
>       | ^~~~~~
> 
> This commit fix it by moving nokprobe_inline to the beginning
> of declaration.
> 

Acked-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>

Thank you!

> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> ---
>  arch/x86/kernel/kprobes/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86/kernel/kprobes/core.c
> index 89d9f26785c7..5abf251f12ec 100644
> --- a/arch/x86/kernel/kprobes/core.c
> +++ b/arch/x86/kernel/kprobes/core.c
> @@ -937,7 +937,7 @@ static int reenter_kprobe(struct kprobe *p, struct pt_regs *regs,
>  }
>  NOKPROBE_SYMBOL(reenter_kprobe);
>  
> -static int nokprobe_inline kprobe_is_ss(struct kprobe_ctlblk *kcb)
> +static nokprobe_inline int kprobe_is_ss(struct kprobe_ctlblk *kcb)
>  {
>  	return (kcb->kprobe_status == KPROBE_HIT_SS ||
>  		kcb->kprobe_status == KPROBE_REENTER);
> 


-- 
Masami Hiramatsu <mhiramat@xxxxxxxxxx>