Re: [PATCH] kernel/sched: remove duplicate include in sched.h sched.h

[Steven Rostedt]

On Thu,  4 Mar 2021 04:09:26 -0800
menglong8.dong@xxxxxxxxx wrote:

> From: Xiong Zhenwu <xiong.zhenwu@xxxxxxxxxx>
> 
> 'linux/psi.h' included in 'kernel/sched/sched.h' is duplicated. it also
> include in 59th line.
> 

Yep, #include <linux/psi.h> is at the top of the file, no need to have
it again in the the CGROUP_SCHED conditional.

Reviewed-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>

-- Steve


> Signed-off-by: Xiong Zhenwu <xiong.zhenwu@xxxxxxxxxx>
> ---
>  kernel/sched/sched.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 10a1522b1e30..235d8381f142 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -344,7 +344,6 @@ extern bool dl_cpu_busy(unsigned int cpu);
>  #ifdef CONFIG_CGROUP_SCHED
>  
>  #include <linux/cgroup.h>
> -#include <linux/psi.h>
>  
>  struct cfs_rq;
>  struct rt_rq;