Re: [PATCH] kconfig: use true and false for bool variable

From: Masahiro Yamada
Date: Thu Mar 25 2021 - 00:48:56 EST


On Mon, Mar 15, 2021 at 3:55 PM Yang Li <yang.lee@xxxxxxxxxxxxxxxxx> wrote:
>
> fixed the following coccicheck:
> ./scripts/kconfig/confdata.c:36:9-10: WARNING: return of 0/1 in function
> 'is_dir' with return type bool
>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>
> ---

Applied. Thanks.




> scripts/kconfig/confdata.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
> index 2568dbe..b65b8c3 100644
> --- a/scripts/kconfig/confdata.c
> +++ b/scripts/kconfig/confdata.c
> @@ -33,7 +33,7 @@ static bool is_dir(const char *path)
> struct stat st;
>
> if (stat(path, &st))
> - return 0;
> + return false;
>
> return S_ISDIR(st.st_mode);
> }
> --
> 1.8.3.1
>


--
Best Regards
Masahiro Yamada