Re: [RFC Part2 PATCH 05/30] x86: define RMP violation #PF error code

From: Dave Hansen
Date: Thu Mar 25 2021 - 10:35:04 EST


On 3/25/21 7:32 AM, Brijesh Singh wrote:
>>> enum x86_pf_error_code {
>>> X86_PF_PROT = 1 << 0,
>>> @@ -21,6 +22,7 @@ enum x86_pf_error_code {
>>> X86_PF_INSTR = 1 << 4,
>>> X86_PF_PK = 1 << 5,
>>> X86_PF_SGX = 1 << 15,
>>> + X86_PF_RMP = 1ull << 31,
>>> };
...
>> Could we at least start declaring these with BIT()?
>
> Sure, I can bit the BIT() macro to define the bits. Do you want me to
> update all of the fault codes to use BIT() or just the one I am adding
> in this patch ?

Please update all of them for consistency.