Re: [PATCH] ima: Fix the error code for restoring the PCR value

From: Mimi Zohar
Date: Thu Mar 25 2021 - 11:11:02 EST


On Wed, 2021-03-24 at 09:00 +0000, Roberto Sassu wrote:
> > From: lihuafei
> > Sent: Tuesday, March 23, 2021 2:41 PM
> > ping. :-)
> >
> > On 2021/3/3 11:28, Li Huafei wrote:
> > > In ima_restore_measurement_list(), hdr[HDR_PCR].data is pointing to a
> > > buffer of type u8, which contains the dumped 32-bit pcr value.
> > > Currently, only the least significant byte is used to restore the pcr
> > > value. We should convert hdr[HDR_PCR].data to a pointer of type u32
> > > before fetching the value to restore the correct pcr value.
> > >
> > > Fixes: 47fdee60b47f ("ima: use ima_parse_buf() to parse measurements
> > headers")
> > > Signed-off-by: Li Huafei <lihuafei1@xxxxxxxxxx>
>
> Hi Li Huafei
>
> yes, correct. Thanks for the patch.
>
> Reviewed-by: Roberto Sassu <roberto.sassu@xxxxxxxxxx>

The patch set is now queued in next-integrity-testing.

thanks,

Mimi