Re: [PATCH v3] cifs: Silently ignore unknown oplock break handle

From: Paulo Alcantara
Date: Thu Mar 25 2021 - 11:42:56 EST


Vincent Whitchurch <vincent.whitchurch@xxxxxxxx> writes:

> Make SMB2 not print out an error when an oplock break is received for an
> unknown handle, similar to SMB1. The debug message which is printed for
> these unknown handles may also be misleading, so fix that too.
>
> The SMB2 lease break path is not affected by this patch.
>
> Without this, a program which writes to a file from one thread, and
> opens, reads, and writes the same file from another thread triggers the
> below errors several times a minute when run against a Samba server
> configured with "smb2 leases = no".
>
> CIFS: VFS: \\192.168.0.1 No task to wake, unknown frame received! NumMids 2
> 00000000: 424d53fe 00000040 00000000 00000012 .SMB@...........
> 00000010: 00000001 00000000 ffffffff ffffffff ................
> 00000020: 00000000 00000000 00000000 00000000 ................
> 00000030: 00000000 00000000 00000000 00000000 ................
>
> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@xxxxxxxx>
> ---
>
> Notes:
> v3:
> - Change debug print to Tom Talpey's suggestion
>
> v2:
> - Drop change to lease break
> - Rewrite commit message
>
> fs/cifs/smb2misc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Paulo Alcantara (SUSE) <pc@xxxxxx>