Re: [RFC PATCH v7 16/22] virtio/vsock: setup SEQPACKET ops for transport

[Arseny Krasnov]

On 25.03.2021 13:39, Stefano Garzarella wrote:
> On Tue, Mar 23, 2021 at 04:14:03PM +0300, Arseny Krasnov wrote:
>> This adds SEQPACKET ops for virtio transport and 'seqpacket_allow()'
>> callback.
>>
>> Signed-off-by: Arseny Krasnov <arseny.krasnov@xxxxxxxxxxxxx>
>> ---
>> net/vmw_vsock/virtio_transport.c | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
> Sorry for not mentioning this in the previous review, but maybe we can 
> merge this patch with "virtio/vsock: SEQPACKET feature bit support", so 
> we have a single patch when we fully enable the SEQPACKET support in 
> this transport.
>
> Anyway, I don't have a strong opinion on that.
>
> What do you think?
Ok, no problem
>
> Stefano
>
>> diff --git a/net/vmw_vsock/virtio_transport.c 
>> b/net/vmw_vsock/virtio_transport.c
>> index 2700a63ab095..83ae2078c847 100644
>> --- a/net/vmw_vsock/virtio_transport.c
>> +++ b/net/vmw_vsock/virtio_transport.c
>> @@ -443,6 +443,8 @@ static void virtio_vsock_rx_done(struct virtqueue *vq)
>> 	queue_work(virtio_vsock_workqueue, &vsock->rx_work);
>> }
>>
>> +static bool virtio_transport_seqpacket_allow(void);
>> +
>> static struct virtio_transport virtio_transport = {
>> 	.transport = {
>> 		.module                   = THIS_MODULE,
>> @@ -469,6 +471,10 @@ static struct virtio_transport virtio_transport = {
>> 		.stream_is_active         = virtio_transport_stream_is_active,
>> 		.stream_allow             = virtio_transport_stream_allow,
>>
>> +		.seqpacket_dequeue        = virtio_transport_seqpacket_dequeue,
>> +		.seqpacket_enqueue        = virtio_transport_seqpacket_enqueue,
>> +		.seqpacket_allow          = virtio_transport_seqpacket_allow,
>> +
>> 		.notify_poll_in           = virtio_transport_notify_poll_in,
>> 		.notify_poll_out          = virtio_transport_notify_poll_out,
>> 		.notify_recv_init         = virtio_transport_notify_recv_init,
>> @@ -483,8 +489,14 @@ static struct virtio_transport virtio_transport = {
>> 	},
>>
>> 	.send_pkt = virtio_transport_send_pkt,
>> +	.seqpacket_allow = false
>> };
>>
>> +static bool virtio_transport_seqpacket_allow(void)
>> +{
>> +	return virtio_transport.seqpacket_allow;
>> +}
>> +
>> static void virtio_transport_rx_work(struct work_struct *work)
>> {
>> 	struct virtio_vsock *vsock =
>> -- 2.25.1
>>
>