Re: [Patch V2 12/13] irqchip: Add IMS (Interrupt Message Store) driver

[Dey, Megha]

Hi Thomas/Marc,

On 3/25/2021 12:07 PM, Thomas Gleixner wrote:
> On Thu, Mar 25 2021 at 17:43, Marc Zyngier wrote:
> > On Fri, 26 Feb 2021 20:11:16 +0000,
> > Megha Dey <megha.dey@xxxxxxxxx> wrote:
> > > +
> > > +#include <linux/irqchip/irq-ims-msi.h>
> > > +
> > > +#ifdef CONFIG_IMS_MSI_ARRAY
> > Given that this covers the whole driver, what is this #defined used
> > for? You might as well make the driver depend on this config option.
> That's a leftover from the initial version I wrote which had also
> support for IMS_MSI_QUEUE to store the message in queue memory, but we
> have no use case yet for it.
>
> But yes, as things stand now it does not make any sense and IIRC at the
> end they do not share anything in the C file except for some includes at
> the very end.
Sure, I will make this change.
> Thanks,
>
>          tglx