Re: [PATCH v5 9/9] dt-bindings: serial: stm32: Use 'type: object' instead of false for 'additionalProperties'

From: dillon min
Date: Thu Mar 25 2021 - 21:55:20 EST


Hi Valentin

On Thu, Mar 25, 2021 at 7:12 PM Valentin CARON - foss
<valentin.caron@xxxxxxxxxxx> wrote:
>
> Hi Dillon,
>
> It's okay for me.
>
> Regards,
>
> Valentin
Thanks for your test, and quick reply.
>
> On 3/25/21 7:19 AM, dillon.minfei@xxxxxxxxx wrote:
> > From: dillon min <dillon.minfei@xxxxxxxxx>
> >
> > To use additional properties 'bluetooth' on serial, need replace false with
> > 'type: object' for 'additionalProperties' to make it as a node, else will
> > run into dtbs_check warnings.
> >
> > 'arch/arm/boot/dts/stm32h750i-art-pi.dt.yaml: serial@40004800:
> > 'bluetooth' does not match any of the regexes: 'pinctrl-[0-9]+'
> >
> > Fixes: af1c2d81695b ("dt-bindings: serial: Convert STM32 UART to json-schema")
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Tested-by: Valentin Caron <valentin.caron@xxxxxxxxxxx>
> > Signed-off-by: dillon min <dillon.minfei@xxxxxxxxx>
> > ---
> >
> > v5: accroding to rob's suggestion, replace false with 'type: object'
> > of 'additionalProperties'.
> >
> > Documentation/devicetree/bindings/serial/st,stm32-uart.yaml | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> > index 8631678283f9..865be05083c3 100644
> > --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> > +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> > @@ -80,7 +80,8 @@ required:
> > - interrupts
> > - clocks
> >
> > -additionalProperties: false
> > +additionalProperties:
> > + type: object
> >
> > examples:
> > - |