Re: [PATCH v2 2/2] leds: leds-multi-gpio: Add multiple GPIOs LED driver

[Hermes Zhang]

On 3/26/21 1:56 PM, Alexander Dahl wrote:
>> +
>> +module_platform_driver(multi_gpio_led_driver);
>> +
>> +MODULE_AUTHOR("Hermes Zhang <chenhui.zhang@xxxxxxxx>");
>> +MODULE_DESCRIPTION("Multiple GPIOs LED driver");
>> +MODULE_LICENSE("GPL v2");
>> +MODULE_ALIAS("platform:leds-multi-gpio");
> I did not review thouroughly, but in my mail the indentation looks
> wrong. Did checkpatch complain?

Sorry, I forgot to check the style before commit, but seems one problem
about extra space:

$ chkernel
ERROR: space prohibited before that ',' (ctx:WxW)
#164: FILE: drivers/leds/simple/leds-multi-gpio.c:76:
+            + sizeof(u8) * nr_states , GFP_KERNEL);
                                                   ^

I will fix it in next commit.


Best Regards,

Hermes