Re: [PATCH] powerpc/iommu/debug: Remove redundant NULL check
From: Daniel Axtens
Date: Fri Mar 26 2021 - 02:13:57 EST
Daniel Axtens <dja@xxxxxxxxxx> writes:
It looks like the kernel test robot also reported this:
"[PATCH] powerpc/iommu/debug: fix ifnullfree.cocci warnings"
Weirdly I don't see it in patchwork.
I'm not sure which one mpe will want to take but either would do.
>> Fix the following coccicheck warnings:
>>
>> ./fs/io_uring.c:5989:4-9: WARNING: NULL check before some freeing
>> functions is not needed.
(Also, while unimportant, that's technically not the error you fix here
as it's for a different file!)
>
> This looks correct to me, and matches the description of debugfs_remove
> in Documentation/filesystems/debugfs.rst.
>
> If you have a number of similar fixes it might be helpful to do them in
> a single bigger patch, but I'm not sure if coccicheck reports much else
> as I don't have coccinelle installed at the moment.
>
> Reviewed-by: Daniel Axtens <dja@xxxxxxxxxx>
>
> Kind regards,
> Daniel