[PATCH 07/18] fs: gfs2: glock: Fix some deficient kernel-doc headers and demote non-conformant ones

From: Lee Jones
Date: Fri Mar 26 2021 - 05:12:51 EST


Fixes the following W=1 kernel build warning(s):

fs/gfs2/glock.c:365: warning: Function parameter or member 'gl' not described in 'do_error'
fs/gfs2/glock.c:365: warning: Function parameter or member 'ret' not described in 'do_error'
fs/gfs2/glock.c:461: warning: Function parameter or member 'new_state' not described in 'state_change'
fs/gfs2/glock.c:1277: warning: Function parameter or member 'delay' not described in 'handle_callback'
fs/gfs2/glock.c:1277: warning: Function parameter or member 'remote' not described in 'handle_callback'
fs/gfs2/glock.c:1578: warning: Function parameter or member 'p' not described in 'nq_m_sync'
fs/gfs2/glock.c:1993: warning: Excess function parameter 'wait' description in 'gfs2_gl_hash_clear'

Cc: Bob Peterson <rpeterso@xxxxxxxxxx>
Cc: Andreas Gruenbacher <agruenba@xxxxxxxxxx>
Cc: cluster-devel@xxxxxxxxxx
Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
---
fs/gfs2/glock.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
index 7cccc5e863a8a..c590e27aaf097 100644
--- a/fs/gfs2/glock.c
+++ b/fs/gfs2/glock.c
@@ -356,7 +356,7 @@ static void gfs2_holder_wake(struct gfs2_holder *gh)
}
}

-/**
+/*
* do_error - Something unexpected has happened during a lock request
*
*/
@@ -453,8 +453,7 @@ static inline struct gfs2_holder *find_first_waiter(const struct gfs2_glock *gl)
/**
* state_change - record that the glock is now in a different state
* @gl: the glock
- * @new_state the new state
- *
+ * @new_state: the new state
*/

static void state_change(struct gfs2_glock *gl, unsigned int new_state)
@@ -1263,7 +1262,7 @@ int gfs2_glock_async_wait(unsigned int num_gh, struct gfs2_holder *ghs)
return ret;
}

-/**
+/*
* handle_callback - process a demote request
* @gl: the glock
* @state: the state the caller wants us to change to
@@ -1568,6 +1567,7 @@ static int glock_compare(const void *arg_a, const void *arg_b)
* nq_m_sync - synchonously acquire more than one glock in deadlock free order
* @num_gh: the number of structures
* @ghs: an array of struct gfs2_holder structures
+ * @p: placeholder for the holder structure to pass back
*
* Returns: 0 on success (all glocks acquired),
* errno on failure (no glocks acquired)
@@ -1984,7 +1984,6 @@ static void dump_glock_func(struct gfs2_glock *gl)
/**
* gfs2_gl_hash_clear - Empty out the glock hash table
* @sdp: the filesystem
- * @wait: wait until it's all gone
*
* Called when unmounting the filesystem.
*/
--
2.27.0