Re: [PATCH] PCI: Disable D3cold support on Intel XMM7360
From: Krzysztof Wilczyński
Date: Fri Mar 26 2021 - 05:25:57 EST
Hi,
Thank you for sending the patch over!
[...]
> +static void pci_fixup_no_d3cold(struct pci_dev *pdev)
> +{
> + pci_info(pdev, "disable D3cold\n");
Not sure how useful this message would generally be? Unless this is
useful to someone who is doing some troubleshooting, etc.
> + pci_d3cold_disable(pdev);
> +}
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x7360, pci_fixup_no_d3cold);
[...]
A small suggestion: a brief comment, perhaps even linking to the
Bugzilla, might be a nice touch here, so that people would know why
D3cold is being disabled for XMM7360, etc.
Krzysztof