Re: [PATCH v6 1/2] Added AMS tsl2591 driver implementation
From: Andy Shevchenko
Date: Fri Mar 26 2021 - 07:03:17 EST
On Fri, Mar 26, 2021 at 12:05 AM Joe Sandom <joe.g.sandom@xxxxxxxxx> wrote:
>
> Driver implementation for AMS/TAOS tsl2591 ambient light sensor.
>
> This driver supports configuration via device tree and sysfs.
> Supported channels for raw infrared light intensity,
> raw combined light intensity and illuminance in lux.
> The driver additionally supports iio events on lower and
> upper thresholds.
>
> This is a very-high sensitivity light-to-digital converter that
> transforms light intensity into a digital signal.
I'm under the impression that you ignored at least half of my comments
[1]. Have you seen them?
[1]: https://lore.kernel.org/linux-iio/CAHp75VcSW2xXdH--rXaN7xt0Ju+qfw9c_va0gGRGPgpBua0H-Q@xxxxxxxxxxxxxx/
Please. address and come again.
NAK for this version, sorry.
--
With Best Regards,
Andy Shevchenko