Re: [PATCH v2 6/9] debugfs: Implement debugfs_create_str()

[Peter Zijlstra]

On Fri, Mar 26, 2021 at 02:10:41PM +0100, Rasmus Villemoes wrote:
> On 26/03/2021 13.57, Greg KH wrote:
> > On Fri, Mar 26, 2021 at 01:53:59PM +0100, Rasmus Villemoes wrote:
> >> On 26/03/2021 12.38, Peter Zijlstra wrote:
> >>
> >>> Implement debugfs_create_str() to easily display names and such in
> >>> debugfs.
> >>
> >> Patches 7-9 don't seem to add any users of this. What's it for precisely?
> > 
> > It's used in patch 7, look close :)
> 
> Ah, macrology. But the write capability doesn't seem used, and I (still)
> fail to see how that could be useful.

Correct, it isn't used. But I didn't think it would be acceptible to
not implement the write side. OTOH, if Greg would be okay with it, I can
change it to:

ssize_t debugfs_write_file_str(struct file *file, const char __user *user_buf,
                               size_t count, loff_t *ppos)
{
        /* This is really only for read-only strings */
        return -EINVAL;
}
EXPORT_SYMBOL_GPL(debugfs_write_file_str);

That's certianly simpler.