Re: [PATCH v3 05/17] arm: Convert to GENERIC_CMDLINE

[Christophe Leroy]

Le 26/03/2021 à 16:47, Rob Herring a écrit :
> On Fri, Mar 26, 2021 at 7:44 AM Christophe Leroy
> <christophe.leroy@xxxxxxxxxx> wrote:
> > This converts the architecture to GENERIC_CMDLINE.
> >
> > Signed-off-by: Christophe Leroy <christophe.leroy@xxxxxxxxxx>
> > ---
> >   arch/arm/Kconfig              | 38 +----------------------------------
> >   arch/arm/kernel/atags_parse.c | 15 +++++---------
> >   2 files changed, 6 insertions(+), 47 deletions(-)
> >
> > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > index 5da96f5df48f..67bc75f2da81 100644
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -50,6 +50,7 @@ config ARM
> >          select GENERIC_ARCH_TOPOLOGY if ARM_CPU_TOPOLOGY
> >          select GENERIC_ATOMIC64 if CPU_V7M || CPU_V6 || !CPU_32v6K || !AEABI
> >          select GENERIC_CLOCKEVENTS_BROADCAST if SMP
> > +       select GENERIC_CMDLINE if ATAGS
>
> Don't we need this enabled for !ATAGS (i.e. DT boot)?
>
> Can we always enable GENERIC_CMDLINE for OF_EARLY_FLATTREE?

Don't know.

Today ARM has:

choice
	prompt "Kernel command line type" if CMDLINE != ""
	default CMDLINE_FROM_BOOTLOADER
	depends on ATAGS



Christophe