Re: [PATCH][next] cifs: cifspdu.h: Replace one-element array with flexible-array member

From: Gustavo A. R. Silva
Date: Fri Mar 26 2021 - 12:37:06 EST




On 3/26/21 10:54, Aurélien Aptel wrote:
> "Gustavo A. R. Silva" <gustavoars@xxxxxxxxxx> writes:
>> There is a regular need in the kernel to provide a way to declare having
>> a dynamically sized set of trailing elements in a structure. Kernel code
>> should always use “flexible array members”[1] for these cases. The older
>> style of one-element or zero-length arrays should no longer be used[2].
>
> I've checked the usages of the struct, looks OK (we don't allocate it
> directly, we use memory from the small/big buff pools).

Awesome. :)

> Reviewed-by: Aurelien Aptel <aaptel@xxxxxxxx>

Thank you, Aurelien.
--
Gustavo