Re: [PATCH v3 1/6] dt-bindings: phy: qcom,qmp-usb3-dp: Add support for SM8250

[Dmitry Baryshkov]

On Fri, 26 Mar 2021 at 04:20, Rob Herring <robh@xxxxxxxxxx> wrote:
>
> On Thu, Mar 18, 2021 at 10:59:25PM +0300, Dmitry Baryshkov wrote:
> > Add compatible for SM8250 in QMP USB3 DP PHY bindings.
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml         | 1 -
> >  Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml | 2 ++
> >  2 files changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> > index 626447fee092..c558aa605b9d 100644
> > --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> > @@ -38,7 +38,6 @@ properties:
> >        - qcom,sm8250-qmp-gen3x1-pcie-phy
> >        - qcom,sm8250-qmp-gen3x2-pcie-phy
> >        - qcom,sm8250-qmp-modem-pcie-phy
> > -      - qcom,sm8250-qmp-usb3-phy
>
> Why is this being moved? Not sure what the differences between the 2
> bindings, but doesn't seem like a backwards compatible change.

Hmm. I followed the existing schemas, but they are incorrect. It looks
like the commit 724fabf5df13 ("dt-bindings: phy: qcom,qmp-usb3-dp: Add
DP phy information") has introduced backwards-incompatible change,
which is not followed by the current kernel device trees. I'd proposed
to move qcom,sc7180-qmp-usb3-phy and qcom,sdm845-qmp-usb3-phy back to
bindings/phy/qcom,qmp-phy.yaml (as those device nodes do not use DP
serdes block, etc).

I'll include the fix into v4 of this series.

>
> >        - qcom,sm8250-qmp-usb3-uni-phy
> >        - qcom,sm8350-qmp-ufs-phy
> >        - qcom,sm8350-qmp-usb3-phy
> > diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml
> > index 33974ad10afe..9792cc567cb5 100644
> > --- a/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml
> > @@ -17,6 +17,8 @@ properties:
> >        - qcom,sc7180-qmp-usb3-phy
> >        - qcom,sdm845-qmp-usb3-dp-phy
> >        - qcom,sdm845-qmp-usb3-phy
> > +      - qcom,sm8250-qmp-usb3-dp-phy
> > +      - qcom,sm8250-qmp-usb3-phy
> >    reg:
> >      items:
> >        - description: Address and length of PHY's USB serdes block.
> > --
> > 2.30.2
> >



-- 
With best wishes
Dmitry