Re: [PATCH v3 3/3] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

From: Andy Shevchenko
Date: Fri Mar 26 2021 - 14:02:58 EST


On Sat, Mar 6, 2021 at 4:08 PM Syed Nayyar Waris <syednwaris@xxxxxxxxx> wrote:

> + bitmap_set_value(old, 64, state[0], 32, 0);
> + bitmap_set_value(old, 64, state[1], 32, 32);

Isn't it effectively bitnap_from_arr32() ?

> + bitmap_set_value(new, 64, state[0], 32, 0);
> + bitmap_set_value(new, 64, state[1], 32, 32);

Ditto.

--
With Best Regards,
Andy Shevchenko