Re: [PATCH v3 3/6] PCI: brcmstb: Do not turn off regulators if EP can wake up

From: Bjorn Helgaas
Date: Fri Mar 26 2021 - 16:18:39 EST


On Fri, Mar 26, 2021 at 03:19:01PM -0400, Jim Quinlan wrote:
> If any downstream device may wake up during S2/S3 suspend, we do not want
> to turn off its power when suspending.
>
> Signed-off-by: Jim Quinlan <jim2101024@xxxxxxxxx>
> ---
> drivers/pci/controller/pcie-brcmstb.c | 58 +++++++++++++++++++++++----
> 1 file changed, 51 insertions(+), 7 deletions(-)

> +enum {
> + TURN_OFF, /* Turn egulators off, unless an EP is wakeup-capable */
> + TURN_OFF_ALWAYS, /* Turn Regulators off, no exceptions */
> + TURN_ON, /* Turn regulators on, unless pcie->ep_wakeup_capable */

s/egulators/regulators/
s/Regulators/regulators/