Re: [PATCH v2 3/3] dt-bindings: qcom: geni-se: document iommus

From: Rob Herring
Date: Sat Mar 27 2021 - 12:41:43 EST


On Sun, Mar 21, 2021 at 05:46:32PM +0000, Caleb Connolly wrote:
> Document the iommus property for QCOM Geni SE.
>
> Signed-off-by: Caleb Connolly <caleb@xxxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
> index 84671950ca0d..68c4ee55ae7d 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
> @@ -51,6 +51,9 @@ properties:
> interconnect-names:
> const: qup-core
>
> + iommus:

Need to define how many entries (maxItems: 1?)

> + description: the iommu and adress to be used to configure DMA for large transfers.

The property doesn't define the address to be used.

> +
> required:
> - compatible
> - reg
> --
> 2.30.2
>
>