Re: [PATCH 1/8] dt-bindings: remoteproc: imx_rproc: add imx,auto-boot property

[Rob Herring]

On Mon, Mar 22, 2021 at 04:12:36PM +0800, peng.fan@xxxxxxxxxxx wrote:
> From: Peng Fan <peng.fan@xxxxxxx>
> 
> Add an optional property "imx,auto-boot" to indicate remote processor
> auto boot.
> 
> Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> ---
>  .../devicetree/bindings/remoteproc/fsl,imx-rproc.yaml       | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
> index 208a628f8d6c..70aec1a2e86d 100644
> --- a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
> @@ -49,6 +49,12 @@ properties:
>      minItems: 1
>      maxItems: 32
>  
> +  imx,auto-boot:

'imx' is not a vendor.

Should be generic?

> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      Indicate whether need to loads the default firmware and starts the remote

need to load ...

> +      processor automatically.
> +
>  required:
>    - compatible
>    - clocks
> -- 
> 2.30.0
>