Re: [PATCH v1 3/8] software node: Show properties and their values in sysfs

From: kernel test robot
Date: Sat Mar 27 2021 - 21:16:15 EST

Hi Andy,

I love your patch! Yet something to improve:

[auto build test ERROR on driver-core/driver-core-testing]
[also build test ERROR on linuxtv-media/master linux/master linus/master v5.12-rc4 next-20210326]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/software-node-Free-resources-explicitly-when-swnode_register-fails/20210328-062322
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git ecdc996baf291b903342cc704f4086a88c361967
config: microblaze-randconfig-r016-20210328 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/1d48129700f39fc70d26e5faee27e6fd7d8d5234
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Andy-Shevchenko/software-node-Free-resources-explicitly-when-swnode_register-fails/20210328-062322
git checkout 1d48129700f39fc70d26e5faee27e6fd7d8d5234
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=microblaze

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

In file included from include/linux/kobject.h:20,
from include/linux/energy_model.h:7,
from include/linux/device.h:16,
from drivers/base/swnode.c:9:
drivers/base/swnode.c: In function 'swnode_register_properties':
>> include/linux/sysfs.h:55:8: error: 'struct kobj_attribute' has no member named 'key'
55 | (attr)->key = &__key; \
| ^~
drivers/base/swnode.c:835:3: note: in expansion of macro 'sysfs_attr_init'
835 | sysfs_attr_init(&attrs[n]);
| ^~~~~~~~~~~~~~~


vim +55 include/linux/sysfs.h

^1da177e4c3f41 Linus Torvalds 2005-04-16 39
35960258ed388c Eric W. Biederman 2010-02-12 40 /**
35960258ed388c Eric W. Biederman 2010-02-12 41 * sysfs_attr_init - initialize a dynamically allocated sysfs attribute
35960258ed388c Eric W. Biederman 2010-02-12 42 * @attr: struct attribute to initialize
35960258ed388c Eric W. Biederman 2010-02-12 43 *
35960258ed388c Eric W. Biederman 2010-02-12 44 * Initialize a dynamically allocated struct attribute so we can
35960258ed388c Eric W. Biederman 2010-02-12 45 * make lockdep happy. This is a new requirement for attributes
35960258ed388c Eric W. Biederman 2010-02-12 46 * and initially this is only needed when lockdep is enabled.
35960258ed388c Eric W. Biederman 2010-02-12 47 * Lockdep gives a nice error when your attribute is added to
35960258ed388c Eric W. Biederman 2010-02-12 48 * sysfs if you don't have this.
35960258ed388c Eric W. Biederman 2010-02-12 49 */
6992f5334995af Eric W. Biederman 2010-02-11 50 #ifdef CONFIG_DEBUG_LOCK_ALLOC
6992f5334995af Eric W. Biederman 2010-02-11 51 #define sysfs_attr_init(attr) \
6992f5334995af Eric W. Biederman 2010-02-11 52 do { \
6992f5334995af Eric W. Biederman 2010-02-11 53 static struct lock_class_key __key; \
6992f5334995af Eric W. Biederman 2010-02-11 54 \
6992f5334995af Eric W. Biederman 2010-02-11 @55 (attr)->key = &__key; \
6992f5334995af Eric W. Biederman 2010-02-11 56 } while (0)
6992f5334995af Eric W. Biederman 2010-02-11 57 #else
6992f5334995af Eric W. Biederman 2010-02-11 58 #define sysfs_attr_init(attr) do {} while (0)
6992f5334995af Eric W. Biederman 2010-02-11 59 #endif
6992f5334995af Eric W. Biederman 2010-02-11 60

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip