Re: [PATCH v4 2/4] riscv: cmpxchg.h: Merge macros

From: Guo Ren
Date: Sat Mar 27 2021 - 21:51:53 EST


Thx Arnd,

On Sun, Mar 28, 2021 at 5:25 AM Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
> On Sat, Mar 27, 2021 at 7:06 PM <guoren@xxxxxxxxxx> wrote:
> >
> > From: Guo Ren <guoren@xxxxxxxxxxxxxxxxx>
> >
> > To reduce assembly codes, let's merge duplicate codes into one
> > (xchg_acquire, xchg_release, cmpxchg_release).
> >
> > Signed-off-by: Guo Ren <guoren@xxxxxxxxxxxxxxxxx>
>
> This is a nice cleanup, but I wonder if you can go even further by using
> the definitions from atomic-arch-fallback.h like arm64 and x86 do.
Ok, I'll separate it from the qspinlock patchset and try atomic-arch-fallback.h.

--
Best Regards
Guo Ren

ML: https://lore.kernel.org/linux-csky/