Re: [PATCH v2 2/3] dt-bindings: iommu: add DART iommu bindings

From: Sven Peter
Date: Sun Mar 28 2021 - 06:04:49 EST




On Sun, Mar 28, 2021, at 10:16, Arnd Bergmann wrote:
> On Sun, Mar 28, 2021 at 9:40 AM Sven Peter <sven@xxxxxxxxxxxxx> wrote:
>
> I noticed only one detail here:
>
> > + - |+
> > + dart2a: dart2a@82f00000 {
> > + compatible = "apple,t8103-dart";
> > + reg = <0x82f00000 0x4000>;
> > + interrupts = <1 781 4>;
> > + #iommu-cells = <1>;
> > + };
>
> The name of the iommu should be iommu@82f00000, not dart2a@82f00000.
>
> Arnd
>

Thanks, fixed for v3. I've also just noticed that I forgot to update
the filename in MAINTAINERS after I renamed it from apple,t8103-dart.yaml
which I've fixed as well.


Sven