RE: Re: [PATCH v3 2/3] arm64: dts: imx8mq-evk: add one regulator used to power up pcie phy

[Richard Zhu]

> -----Original Message-----
> From: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
> Sent: Friday, March 26, 2021 5:40 PM
> To: Richard Zhu <hongxing.zhu@xxxxxxx>; andrew.smirnov@xxxxxxxxx;
> shawnguo@xxxxxxxxxx; kw@xxxxxxxxx; bhelgaas@xxxxxxxxxx;
> stefan@xxxxxxxx; lorenzo.pieralisi@xxxxxxx
> Cc: linux-pci@xxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> kernel@xxxxxxxxxxxxxx
> Subject: Re: [PATCH v3 2/3] arm64: dts: imx8mq-evk: add one regulator
> used to power up pcie phy
> Am Donnerstag, dem 25.03.2021 um 16:44 +0800 schrieb Richard Zhu:
> > Both 1.8v and 3.3v power supplies can be used by i.MX8MQ PCIe PHY.
> > In default, the PCIE_VPH voltage is suggested to be 1.8v refer to data
> > sheet. When PCIE_VPH is supplied by 3.3v in the HW schematic design,
> > the VREG_BYPASS bits of GPR registers should be cleared from default
> > value 1b'1 to 1b'0. Thus, the internal 3v3 to 1v8 translator would be
> > turned on.
> >
> > Signed-off-by: Richard Zhu <hongxing.zhu@xxxxxxx>
> 
> Reviewed-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
> 
> I guess you need to split this patch out of the series and post it for Shawn to
> pick up into the imx DT tree, after the other two patches of the series have
> been accepted into the PCIe tree.
[Richard Zhu] Sure it is. Shawn had been included in this review loop.
Would split this patch out of this set, and post it for Shawn lonely, after the other two
 Patches are accepted into the PCIe tree.
> 
> Regards,
> Lucas
> 
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> > b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> > index 85b045253a0e..4d2035e3dd7c 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> > @@ -318,6 +318,7 @@
> >                <&clk IMX8MQ_CLK_PCIE1_PHY>,
> >                <&pcie0_refclk>;
> >       clock-names = "pcie", "pcie_aux", "pcie_phy", "pcie_bus";
> > +     vph-supply = <&vgen5_reg>;
> >       status = "okay";
> >  };
> >
> >
> >
> >
>