RE: [PATCH] arch: nios2: fix unmet dependency for SERIAL_CORE_CONSOLE

[Tan, Ley Foon]

> -----Original Message-----
> From: Julian Braha <julian.braha@xxxxxxxxx> On Behalf Of Julian Braha
> Sent: Saturday, March 27, 2021 2:56 AM
> To: Tan, Ley Foon <ley.foon.tan@xxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; fazilyildiran@xxxxxxxxx
> Subject: [PATCH] arch: nios2: fix unmet dependency for
> SERIAL_CORE_CONSOLE
> 
> When EARLY_PRINTK is enabled and TTY is disabled, Kbuild gives the
> following warning:
> 
> WARNING: unmet direct dependencies detected for
> SERIAL_CORE_CONSOLE
>   Depends on [n]: TTY [=n] && HAS_IOMEM [=y]
>   Selected by [y]:
>   - EARLY_PRINTK [=y]
> 
> This is because EARLY_PRINTK selects SERIAL_CORE_CONSOLE without
> selecting or depending on TTY, despite SERIAL_CORE_CONSOLE depending
> on TTY.
> 
> Signed-off-by: Julian Braha <julianbraha@xxxxxxxxx>
> ---
>  arch/nios2/Kconfig.debug | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/nios2/Kconfig.debug b/arch/nios2/Kconfig.debug index
> a8bc06e96ef5..f453d5c1fd38 100644
> --- a/arch/nios2/Kconfig.debug
> +++ b/arch/nios2/Kconfig.debug
> @@ -3,6 +3,7 @@
>  config EARLY_PRINTK
>  	bool "Activate early kernel debugging"
>  	default y
> +	depends on TTY
>  	select SERIAL_CORE_CONSOLE
>  	help
>  	  Enable early printk on console
> --
> 2.25.1

Acked-by: Ley Foon Tan <ley.foon.tan@xxxxxxxxx>