Re: [PATCH v2 01/13] dt-bindings: usb: mtk-xhci: support property usb2-lpm-disable

[Chunfeng Yun]

On Sat, 2021-03-27 at 11:24 -0600, Rob Herring wrote:
> On Tue, Mar 23, 2021 at 03:02:43PM +0800, Chunfeng Yun wrote:
> > Add support common property usb2-lpm-disable
> > 
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@xxxxxxxxxxxx>
> > ---
> > v2: no changes
> > ---
> >  Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> > index 14f40efb3b22..2246d29a5e4e 100644
> > --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> > @@ -103,6 +103,10 @@ properties:
> >      description: supports USB3.0 LPM
> >      type: boolean
> >  
> > +  usb2-lpm-disable:
> > +    description: disable USB2 HW LPM
> > +    type: boolean
> 
> Already has a type. Don't redefine here. Just 'usb2-lpm-disable: true' 
> and make sure usb-xhci.yaml is referenced.
Ok, thanks
> 
> > +
> >    imod-interval-ns:
> >      description:
> >        Interrupt moderation interval value, it is 8 times as much as that
> > -- 
> > 2.18.0
> >