Re: [PATCH 0/3] iio: adc: ad7923: convert driver resources routines to device-managed counterparts

From: Alexandru Ardelean
Date: Mon Mar 29 2021 - 03:19:32 EST


On Mon, Mar 29, 2021 at 12:48 AM Lucas Stankus
<lucas.p.stankus@xxxxxxxxx> wrote:
>
> Following the initiative proposed by Alexandru, this patch series aims
> to convert the ad7923 to use only device-managed routines.
>

This idea is becoming popular it seems :)

Thanks to Lars for pointing out that spi_set_drvdata() omission.
With that fixed:

Reviewed-by: Alexandru Ardelean <ardeleanalex@xxxxxxxxx>

If you want, you can also search for more of these xxx_set_drvdata() omissions.
There were more conversions to devm_ that forgot to remove those.
Maybe a cocci script would be nice to find them.
But all this is optional. Only if you want.

> Part of the driver was already using devm_ functions, so it was possible
> to convert the remainder of it without much hassle.
>
> With that, the deregistration function was no longer necessary and could
> be entirely removed from the driver.
>
> Lucas Stankus (3):
> iio: adc: ad7923: use devm_add_action_or_reset for regulator disable
> iio: adc: ad7923: use device-managed function for triggered buffer
> iio: adc: ad7923: register device with devm_iio_device_register
>
> drivers/iio/adc/ad7923.c | 39 +++++++++++++--------------------------
> 1 file changed, 13 insertions(+), 26 deletions(-)
>
> --
> 2.31.0
>