Re: [PATCH 03/17] ASoC: atmel: atmel-i2s: remove useless initialization

From: Codrin.Ciubotariu
Date: Mon Mar 29 2021 - 03:33:07 EST


On 26.03.2021 23:59, Pierre-Louis Bossart wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Cppcheck complains:
>
> sound/soc/atmel/atmel-i2s.c:628:6: style: Redundant initialization for 'err'. The initialized value is overwritten before it is read. [redundantInitialization]
> err = devm_request_irq(&pdev->dev, irq, atmel_i2s_interrupt, 0,
> ^
> sound/soc/atmel/atmel-i2s.c:598:10: note: err is initialized
> int err = -ENXIO;
> ^
> sound/soc/atmel/atmel-i2s.c:628:6: note: err is overwritten
> err = devm_request_irq(&pdev->dev, irq, atmel_i2s_interrupt, 0,
> ^
>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>

Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@xxxxxxxxxxxxx>

Thanks!