Re: [PATCH net-next v2] net: axienet: Remove redundant dev_err call in axienet_probe()

From: Michal Simek
Date: Mon Mar 29 2021 - 03:46:10 EST




On 3/29/21 3:45 AM, Huang Guobin wrote:
> From: Guobin Huang <huangguobin4@xxxxxxxxxx>
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Guobin Huang <huangguobin4@xxxxxxxxxx>
> ---
> drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> index 5d677db0aee5..f77a794540fc 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> @@ -1878,7 +1878,6 @@ static int axienet_probe(struct platform_device *pdev)
> ethres = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> lp->regs = devm_ioremap_resource(&pdev->dev, ethres);
> if (IS_ERR(lp->regs)) {
> - dev_err(&pdev->dev, "could not map Axi Ethernet regs.\n");
> ret = PTR_ERR(lp->regs);
> goto cleanup_clk;
> }
>

I have already reviewed v1 and I can't see any v2 description what has
changed. Why am I getting this v2? Where is my tag?

Thanks,
Michal