Re: [PATCH v3 03/18] ovl: stack fileattr ops

From: Miklos Szeredi
Date: Mon Mar 29 2021 - 05:25:24 EST


On Sun, Mar 28, 2021 at 8:09 PM Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>
> On Thu, Mar 25, 2021 at 08:37:40PM +0100, Miklos Szeredi wrote:
> > Add stacking for the fileattr operations.
> >
> > Add hack for calling security_file_ioctl() for now. Probably better to
> > have a pair of specific hooks for these operations.
>
> Umm... Shouldn't you remove the old code from their ->ioctl() instance?

Will do, once fuse gets converted.

And fuse will get converted, when I manage to decide on the best way to do it:

1) keep a list of open files for each inode, pick random one for doing
the ioctl (really shouldn't matter which one)

2) do a sequence of open - [sg]et attr - release for each invocation

Thanks,
Miklos