Re: [PATCH] drivers: iio: adc: fix unmet dependency on OF

From: Andy Shevchenko
Date: Mon Mar 29 2021 - 07:19:06 EST


On Mon, Mar 29, 2021 at 9:43 AM Alexandru Ardelean
<ardeleanalex@xxxxxxxxx> wrote:
> On Sun, Mar 28, 2021 at 7:08 AM Julian Braha <julianbraha@xxxxxxxxx> wrote:
> >
> > When AD9467 is enabled, and OF is disabled,
> > Kbuild gives the following warning:
> >
> > WARNING: unmet direct dependencies detected for ADI_AXI_ADC
> > Depends on [n]: IIO [=y] && HAS_IOMEM [=y] && OF [=n]
> > Selected by [y]:
> > - AD9467 [=y] && IIO [=y] && SPI [=y]
> >
> > This is because AD9467 selects ADI_AXI_ADC
> > without selecting or depending on OF,
> > despite ADI_AXI_ADC depending on OF.

> Thanks for the patch.
> This should have been fixed a bit differently with patch:
> https://patchwork.kernel.org/project/linux-iio/patch/20210324182746.9337-1-aardelean@xxxxxxxxxxx/
>
> Can you check if this fixes your setup?

I have to add for sake of the clarification that we are trying really
hard to make drivers agnostic to the device tree provider. In such a
case the same driver can work for all existing providers (ACPI, DT,
and board files with use of software nodes).

--
With Best Regards,
Andy Shevchenko