Re: [PATCH 23/25] HID: hid-sensor-hub: Move 'hsdev' description to correct struct definition

[Jonathan Cameron]

On Fri, 26 Mar 2021 14:34:56 +0000
Lee Jones <lee.jones@xxxxxxxxxx> wrote:

> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/hid/hid-sensor-hub.c:54: warning: Function parameter or member 'hsdev' not described in 'hid_sensor_hub_callbacks_list'
> 

Perhaps nice to mention that this was a result of

ca2ed12f163b ("HID: hid-sensor-hub: Processing for duplicate physical ids")

> Cc: Jiri Kosina <jikos@xxxxxxxxxx>
> Cc: Jonathan Cameron <jic23@xxxxxxxxxx>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> Cc: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>
> Cc: linux-input@xxxxxxxxxxxxxxx
> Cc: linux-iio@xxxxxxxxxxxxxxx
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
Acked-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>

> ---
>  drivers/hid/hid-sensor-hub.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
> index 36b6852f75dd5..95cf88f3bafb9 100644
> --- a/drivers/hid/hid-sensor-hub.c
> +++ b/drivers/hid/hid-sensor-hub.c
> @@ -18,7 +18,6 @@
>  
>  /**
>   * struct sensor_hub_data - Hold a instance data for a HID hub device
> - * @hsdev:		Stored hid instance for current hub device.
>   * @mutex:		Mutex to serialize synchronous request.
>   * @lock:		Spin lock to protect pending request structure.
>   * @dyn_callback_list:	Holds callback function
> @@ -41,6 +40,7 @@ struct sensor_hub_data {
>   * struct hid_sensor_hub_callbacks_list - Stores callback list
>   * @list:		list head.
>   * @usage_id:		usage id for a physical device.
> + * @hsdev:		Stored hid instance for current hub device.
>   * @usage_callback:	Stores registered callback functions.
>   * @priv:		Private data for a physical device.
>   */