Re: [PATCH 2/2] gpiolib: Allow drivers to return EOPNOTSUPP from config

From: Andy Shevchenko
Date: Mon Mar 29 2021 - 08:00:14 EST


On Mon, Mar 29, 2021 at 2:43 PM Matti Vaittinen
<matti.vaittinen@xxxxxxxxxxxxxxxxx> wrote:
>
> The checkpacth instructs to switch from ENOSUPP to EOPNOTSUPP.
> > WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP
>
> Make the gpiolib allow drivers to return both so driver developers
> can avoid one of the checkpatch complaints.

Internally we are fine to use the ENOTSUPP.
Checkpatch false positives there.

I doubt we need this change. Rather checkpatch should rephrase this to
point out that this is only applicable to _user-visible_ error path.
Cc'ed Joe.

--
With Best Regards,
Andy Shevchenko