Re: [PATCH -next 2/2] mISDN: Use LIST_HEAD() for list_head

From: kernel test robot
Date: Mon Mar 29 2021 - 10:08:36 EST


Hi Shixin,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on next-20210326]

url: https://github.com/0day-ci/linux/commits/Shixin-Liu/mISDN-Use-DEFINE_SPINLOCK-for-spinlock/20210329-174318
base: 931294922e65a23e1aad6398b9ae02df74044679
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/84af06fb48f2fff97ae6c5788eb4c572ee2c64e6
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Shixin-Liu/mISDN-Use-DEFINE_SPINLOCK-for-spinlock/20210329-174318
git checkout 84af06fb48f2fff97ae6c5788eb4c572ee2c64e6
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

In file included from include/linux/preempt.h:11,
from include/linux/spinlock.h:51,
from include/linux/mmzone.h:8,
from include/linux/gfp.h:6,
from drivers/isdn/mISDN/dsp_core.c:155:
>> include/linux/list.h:24:2: error: expected '{' before 'struct'
24 | struct list_head name = LIST_HEAD_INIT(name)
| ^~~~~~
drivers/isdn/mISDN/dsp_core.c:180:8: note: in expansion of macro 'LIST_HEAD'
180 | struct LIST_HEAD(dsp_ilist);
| ^~~~~~~~~
>> include/linux/list.h:24:2: error: two or more data types in declaration specifiers
24 | struct list_head name = LIST_HEAD_INIT(name)
| ^~~~~~
drivers/isdn/mISDN/dsp_core.c:180:8: note: in expansion of macro 'LIST_HEAD'
180 | struct LIST_HEAD(dsp_ilist);
| ^~~~~~~~~
>> include/linux/list.h:24:2: error: expected '{' before 'struct'
24 | struct list_head name = LIST_HEAD_INIT(name)
| ^~~~~~
drivers/isdn/mISDN/dsp_core.c:181:8: note: in expansion of macro 'LIST_HEAD'
181 | struct LIST_HEAD(conf_ilist);
| ^~~~~~~~~
>> include/linux/list.h:24:2: error: two or more data types in declaration specifiers
24 | struct list_head name = LIST_HEAD_INIT(name)
| ^~~~~~
drivers/isdn/mISDN/dsp_core.c:181:8: note: in expansion of macro 'LIST_HEAD'
181 | struct LIST_HEAD(conf_ilist);
| ^~~~~~~~~


vim +24 include/linux/list.h

^1da177e4c3f41 Linus Torvalds 2005-04-16 22
^1da177e4c3f41 Linus Torvalds 2005-04-16 23 #define LIST_HEAD(name) \
^1da177e4c3f41 Linus Torvalds 2005-04-16 @24 struct list_head name = LIST_HEAD_INIT(name)
^1da177e4c3f41 Linus Torvalds 2005-04-16 25

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip