Re: [PATCH mvebu v2 09/10] cpufreq: armada-37xx: Remove cur_frequency variable

From: Gregory CLEMENT
Date: Mon Mar 29 2021 - 11:01:05 EST


Pali Rohár <pali@xxxxxxxxxx> writes:

> Variable cur_frequency in armada37xx_cpufreq_driver_init() is unused.
>
> Signed-off-by: Pali Rohár <pali@xxxxxxxxxx>

Acked-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxx>

Thanks,

Gregory

> ---
> drivers/cpufreq/armada-37xx-cpufreq.c | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/cpufreq/armada-37xx-cpufreq.c b/drivers/cpufreq/armada-37xx-cpufreq.c
> index f08281fc525c..f13646d143de 100644
> --- a/drivers/cpufreq/armada-37xx-cpufreq.c
> +++ b/drivers/cpufreq/armada-37xx-cpufreq.c
> @@ -389,7 +389,7 @@ static int __init armada37xx_cpufreq_driver_init(void)
> struct armada_37xx_dvfs *dvfs;
> struct platform_device *pdev;
> unsigned long freq;
> - unsigned int cur_frequency, base_frequency;
> + unsigned int base_frequency;
> struct regmap *nb_clk_base, *nb_pm_base, *avs_base;
> struct device *cpu_dev;
> int load_lvl, ret;
> @@ -450,14 +450,6 @@ static int __init armada37xx_cpufreq_driver_init(void)
> return -EINVAL;
> }
>
> - /* Get nominal (current) CPU frequency */
> - cur_frequency = clk_get_rate(clk);
> - if (!cur_frequency) {
> - dev_err(cpu_dev, "Failed to get clock rate for CPU\n");
> - clk_put(clk);
> - return -EINVAL;
> - }
> -
> dvfs = armada_37xx_cpu_freq_info_get(base_frequency);
> if (!dvfs) {
> clk_put(clk);
> --
> 2.20.1
>

--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com