Re: [PATCH] drm: DON'T require each CRTC to have a unique primary plane

From: Paul Cercueil
Date: Mon Mar 29 2021 - 11:16:33 EST


Hi Maxime,

Le lun. 29 mars 2021 à 16:07, Maxime Ripard <maxime@xxxxxxxxxx> a écrit :
On Sat, Mar 27, 2021 at 11:22:14AM +0000, Paul Cercueil wrote:
The ingenic-drm driver has two mutually exclusive primary planes
already; so the fact that a CRTC must have one and only one primary
plane is an invalid assumption.

I mean, no? It's been documented for a while that a CRTC should only
have a single primary, so I'd say that the invalid assumption was that
it was possible to have multiple primary planes for a CRTC.

Documented where?

I did read the doc of "enum drm_plane_type" in <drm/drm_plane.h>, and the DRM_PLANE_TYPE_PRIMARY describes my two planes, so I went with that.

-Paul

Since it looks like you have two mutually exclusive planes, just expose
one and be done with it?

Maxime