Re: [PATCH 06/12] platform/x86: intel_cht_int33fe_microb: Constify the software node
From: Hans de Goede
Date: Mon Mar 29 2021 - 11:28:49 EST
Hi,
On 3/29/21 12:50 PM, Heikki Krogerus wrote:
> Additional device properties are always just a part of a
> software fwnode. If the device properties are constant, the
> software node can also be constant.
>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> Cc: Hans de Goede <hdegoede@xxxxxxxxxx>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>
What is the plan for merging this patch / this series ?
Regards,
Hans
> ---
> drivers/platform/x86/intel_cht_int33fe_microb.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel_cht_int33fe_microb.c b/drivers/platform/x86/intel_cht_int33fe_microb.c
> index 20b11e0d9a758..673f41cd14b52 100644
> --- a/drivers/platform/x86/intel_cht_int33fe_microb.c
> +++ b/drivers/platform/x86/intel_cht_int33fe_microb.c
> @@ -35,6 +35,10 @@ static const struct property_entry bq27xxx_props[] = {
> { }
> };
>
> +static const struct software_node bq27xxx_node = {
> + .properties = bq27xxx_props,
> +};
> +
> int cht_int33fe_microb_probe(struct cht_int33fe_data *data)
> {
> struct device *dev = data->dev;
> @@ -43,7 +47,7 @@ int cht_int33fe_microb_probe(struct cht_int33fe_data *data)
> memset(&board_info, 0, sizeof(board_info));
> strscpy(board_info.type, "bq27542", ARRAY_SIZE(board_info.type));
> board_info.dev_name = "bq27542";
> - board_info.properties = bq27xxx_props;
> + board_info.swnode = &bq27xxx_node;
> data->battery_fg = i2c_acpi_new_device(dev, 1, &board_info);
>
> return PTR_ERR_OR_ZERO(data->battery_fg);
>