Re: [PATCH v3 16/16] objtool,x86: Rewrite retpoline thunk calls

From: Josh Poimboeuf
Date: Mon Mar 29 2021 - 12:39:33 EST


On Fri, Mar 26, 2021 at 04:12:15PM +0100, Peter Zijlstra wrote:
> @@ -61,3 +89,15 @@ SYM_FUNC_END(__x86_indirect_thunk_\reg)
> #define GEN(reg) EXPORT_THUNK(reg)
> #include <asm/GEN-for-each-reg.h>
>
> +#undef GEN
> +#define GEN(reg) ALT_THUNK reg
> +#include <asm/GEN-for-each-reg.h>
> +
> +#undef GEN
> +#define GEN(reg) __EXPORT_THUNK(__x86_indirect_alt_call_ ## reg)
> +#include <asm/GEN-for-each-reg.h>
> +
> +#undef GEN
> +#define GEN(reg) __EXPORT_THUNK(__x86_indirect_alt_jmp_ ## reg)
> +#include <asm/GEN-for-each-reg.h>
> +

Git complains about this last newline.

Otherwise everything looks pretty good to me. Let me run it through the
test matrix.

--
Josh