Re: [PATCH -next] fs: dlm: fix missing unlock on error in accept_from_sock()
From: David Teigland
Date: Mon Mar 29 2021 - 14:31:17 EST
On Sat, Mar 27, 2021 at 04:37:04PM +0800, Yang Yingliang wrote:
> Add the missing unlock before return from accept_from_sock()
> in the error handling case.
Thanks, applied to the next branch.
Dave
> Fixes: 6cde210a9758 ("fs: dlm: add helper for init connection")
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> ---
> fs/dlm/lowcomms.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c
> index 73cc1809050a..166e36fcf3e4 100644
> --- a/fs/dlm/lowcomms.c
> +++ b/fs/dlm/lowcomms.c
> @@ -931,6 +931,7 @@ static int accept_from_sock(struct listen_connection *con)
> result = dlm_con_init(othercon, nodeid);
> if (result < 0) {
> kfree(othercon);
> + mutex_unlock(&newcon->sock_mutex);
> goto accept_err;
> }
>
> --
> 2.25.1