Re: Linux 5.12-rc5

From: Guenter Roeck
Date: Mon Mar 29 2021 - 15:44:03 EST


On 3/29/21 11:05 AM, Linus Torvalds wrote:
> On Sun, Mar 28, 2021 at 7:07 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
>>
>> This is not really a new problem. I enabled devicetree unit tests
>> in the openrisc kernel and was rewarded with a crash.
>> https://lore.kernel.org/lkml/20210327224116.69309-1-linux@xxxxxxxxxxxx/
>> has all the glorious details.
>
> Hmm.
>
> I'm not sure I love that patch.
>

Me not either. I did point out that it doesn't fix the problem, only
the impact. Fixing the dt unittest code would have been easy enough,
but I wasn't sure how to properly address the problem in the dt overlay
code, and I was concerned that other code might be affected as well,
so I gave up trying and settled on error handling.

Looks like Frank is going to provide a proper fix, so we should be covered.

Thanks,
Guenter