Re: [PATCH] sched/psi.c: Rudimentary typo fixes

From: Shuah Khan
Date: Mon Mar 29 2021 - 17:50:33 EST


On 3/26/21 1:42 PM, Bhaskar Chowdhury wrote:
On 19:41 Fri 26 Mar 2021, Peter Zijlstra wrote:
On Fri, Mar 26, 2021 at 02:00:18PM -0400, Johannes Weiner wrote:
On Fri, Mar 26, 2021 at 06:12:33PM +0530, Bhaskar Chowdhury wrote:
>
> s/possible/possible/
> s/ exceution/execution/
> s/manupulations/manipulations/
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@xxxxxxxxx>
> ---
>  kernel/sched/psi.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
> index 967732c0766c..316ebc57a115 100644
> --- a/kernel/sched/psi.c
> +++ b/kernel/sched/psi.c
> @@ -59,7 +59,7 @@
>   * states, we would have to conclude a CPU SOME pressure number of
>   * 100%, since *somebody* is waiting on a runqueue at all
>   * times. However, that is clearly not the amount of contention the
> - * workload is experiencing: only one out of 256 possible exceution
> + * workload is experiencing: only one out of 256 possible execution

I thought this was the french spelling.

Joking aside, the corrections look right, but I also had no trouble
understanding what those sentences mean. Typos happen, plus we have a
lot of non-native speakers who won't use perfect spelling or grammar.

So for me, the bar is "this can be easily understood", not "needs to
be perfect English", and I'd say let's skip patches like these unless
they fix something truly unintelligble.

Ignore this robot, lots of people already have a special mail rule for
him. On top of that, this spelling mistake was already fixed by Ingo in:


Dude, this is a human being and you are suggesting a fucking stupid solution
to others. I know what Ingo did and very appreciable. Please try to be
cooperative and help. Stop spreading FUD ...for fuck's sake ...man..

I am not doing it fun...you need to understand that . ...


..and I have some special rule for some people to ...who the fuck care
...ahhhhhhhhhh

Bhaskar Chowdhury,

Please be advised that we have received a CoC complaint about your
responses to the following patch discussions:

- https://lore.kernel.org/lkml/YGFrvwX8QngvwPbA@Gentoo/
- https://lore.kernel.org/lkml/YF45Qi+%2FeB+%2Fm7y%2F@Gentoo/
- https://lore.kernel.org/lkml/YF44jiYiAVkuwE0P@Gentoo/
- https://lore.kernel.org/r/YGHOxwiqwhGAs819@Gentoo

There is no requirement that anyone accept your patches. Accepting
feedback and working with the community will ensure that your work
will be taken seriously now and in the future.

Your responses go against the CoC. If this continues, we will take
action to add you to the kernel wide blacklist.

Please refer to:
https://www.kernel.org/doc/html/latest/process/code-of-conduct.html

thanks,
-- Shuah (on behalf of the Code of Conduct Committee)