Re: [External] [PATCH] linux/memcontrol.h: Remove duplicate struct declaration

From: Muchun Song
Date: Mon Mar 29 2021 - 22:14:41 EST


On Tue, Mar 30, 2021 at 10:03 AM Wan Jiabing <wanjiabing@xxxxxxxx> wrote:
>
> struct mem_cgroup is declared twice. One has been declared
> at forward struct declaration. Remove the duplicate.
>
> Signed-off-by: Wan Jiabing <wanjiabing@xxxxxxxx>

Reviewed-by: Muchun Song <songmuchun@xxxxxxxxxxxxx>

Thanks.

> ---
> include/linux/memcontrol.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
> index 0c04d39a7967..f0ae33a0f175 100644
> --- a/include/linux/memcontrol.h
> +++ b/include/linux/memcontrol.h
> @@ -1068,8 +1068,6 @@ void split_page_memcg(struct page *head, unsigned int nr);
> #define MEM_CGROUP_ID_SHIFT 0
> #define MEM_CGROUP_ID_MAX 0
>
> -struct mem_cgroup;
> -
> static inline struct mem_cgroup *page_memcg(struct page *page)
> {
> return NULL;
> --
> 2.25.1
>