Re: [PATCH] nvmem: Change to unified property interface

[kernel test robot]

Hi Kevin,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.12-rc5 next-20210329]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Kevin-Paul-Herbert/nvmem-Change-to-unified-property-interface/20210330-064121
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 1e43c377a79f9189fea8f2711b399d4e8b4e609b
config: x86_64-randconfig-a014-20210329 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 482283042f795ecc27838a3b2f76b5494991401c)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/edbc7632702cf638265a6d7180bd8c951cda6ad9
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Kevin-Paul-Herbert/nvmem-Change-to-unified-property-interface/20210330-064121
        git checkout edbc7632702cf638265a6d7180bd8c951cda6ad9
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   drivers/thermal/sprd_thermal.c:128:9: error: implicit declaration of function 'of_nvmem_cell_get' [-Werror,-Wimplicit-function-declaration]
           cell = of_nvmem_cell_get(np, cell_id);
                  ^
   drivers/thermal/sprd_thermal.c:128:9: note: did you mean 'nvmem_cell_get'?
   include/linux/nvmem-consumer.h:60:20: note: 'nvmem_cell_get' declared here
   struct nvmem_cell *nvmem_cell_get(struct device *dev, const char *id);
                      ^
>> drivers/thermal/sprd_thermal.c:128:7: warning: incompatible integer to pointer conversion assigning to 'struct nvmem_cell *' from 'int' [-Wint-conversion]
           cell = of_nvmem_cell_get(np, cell_id);
                ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   1 warning and 1 error generated.


vim +128 drivers/thermal/sprd_thermal.c

554fdbaf19b188 Freeman Liu 2020-02-18  120  
554fdbaf19b188 Freeman Liu 2020-02-18  121  static int sprd_thm_cal_read(struct device_node *np, const char *cell_id,
554fdbaf19b188 Freeman Liu 2020-02-18  122  			     u32 *val)
554fdbaf19b188 Freeman Liu 2020-02-18  123  {
554fdbaf19b188 Freeman Liu 2020-02-18  124  	struct nvmem_cell *cell;
554fdbaf19b188 Freeman Liu 2020-02-18  125  	void *buf;
554fdbaf19b188 Freeman Liu 2020-02-18  126  	size_t len;
554fdbaf19b188 Freeman Liu 2020-02-18  127  
554fdbaf19b188 Freeman Liu 2020-02-18 @128  	cell = of_nvmem_cell_get(np, cell_id);
554fdbaf19b188 Freeman Liu 2020-02-18  129  	if (IS_ERR(cell))
554fdbaf19b188 Freeman Liu 2020-02-18  130  		return PTR_ERR(cell);
554fdbaf19b188 Freeman Liu 2020-02-18  131  
554fdbaf19b188 Freeman Liu 2020-02-18  132  	buf = nvmem_cell_read(cell, &len);
554fdbaf19b188 Freeman Liu 2020-02-18  133  	nvmem_cell_put(cell);
554fdbaf19b188 Freeman Liu 2020-02-18  134  	if (IS_ERR(buf))
554fdbaf19b188 Freeman Liu 2020-02-18  135  		return PTR_ERR(buf);
554fdbaf19b188 Freeman Liu 2020-02-18  136  
554fdbaf19b188 Freeman Liu 2020-02-18  137  	if (len > sizeof(u32)) {
554fdbaf19b188 Freeman Liu 2020-02-18  138  		kfree(buf);
554fdbaf19b188 Freeman Liu 2020-02-18  139  		return -EINVAL;
554fdbaf19b188 Freeman Liu 2020-02-18  140  	}
554fdbaf19b188 Freeman Liu 2020-02-18  141  
554fdbaf19b188 Freeman Liu 2020-02-18  142  	memcpy(val, buf, len);
554fdbaf19b188 Freeman Liu 2020-02-18  143  
554fdbaf19b188 Freeman Liu 2020-02-18  144  	kfree(buf);
554fdbaf19b188 Freeman Liu 2020-02-18  145  	return 0;
554fdbaf19b188 Freeman Liu 2020-02-18  146  }
554fdbaf19b188 Freeman Liu 2020-02-18  147  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip