Re: [PATCH v2 0/2] soc: mediatek: Prepare MMSYS for DDP routing using tables

[Matthias Brugger]

On 17/03/2021 19:17, Enric Balletbo i Serra wrote:
> Dear all,
> 
> This is the second version of this series intended to prepare the
> mtk-mmsys driver to allow different DDP (Data Display Path) routing
> tables per SoC. Note that the series has been tested only on MT8173 platform,
> for MT2701 and MT2712 based devices we're using a default routing table
> that should just work.

That's a good base to improve the driver.
Things I'd like to see:

Split the mmsys_default_routing_table in the SoC specific one. But each SoC
specific routing table in a new header file.

Whole series applied to v5.12-next/soc

Thanks a lot!
Matthias

> 
> Thanks,
>   Enric
> 
> Changes in v2:
> - Use a default table for mt2701, mt2712 and mt8173.
> - Remove the mask field from routes struct as is not needed.
> 
> CK Hu (2):
>   soc: mediatek: mmsys: Create struct mtk_mmsys to store context data
>   soc: mediatek: mmsys: Use an array for setting the routing registers
> 
>  drivers/soc/mediatek/mtk-mmsys.c | 300 +++++--------------------------
>  drivers/soc/mediatek/mtk-mmsys.h | 215 ++++++++++++++++++++++
>  2 files changed, 257 insertions(+), 258 deletions(-)
>  create mode 100644 drivers/soc/mediatek/mtk-mmsys.h
>