RE: [EXT] [PATCH] scsi: qedi: emove redundant assignment to variable err

[Manish Rangankar]

> -----Original Message-----
> From: Colin King <colin.king@xxxxxxxxxxxxx>
> Sent: Sunday, March 28, 2021 4:37 AM
> To: Nilesh Javali <njavali@xxxxxxxxxxx>; Manish Rangankar
> <mrangankar@xxxxxxxxxxx>; GR-QLogic-Storage-Upstream <GR-QLogic-
> Storage-Upstream@xxxxxxxxxxx>; James E . J . Bottomley
> <jejb@xxxxxxxxxxxxx>; Martin K . Petersen <martin.petersen@xxxxxxxxxx>;
> linux-scsi@xxxxxxxxxxxxxxx
> Cc: kernel-janitors@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [EXT] [PATCH] scsi: qedi: emove redundant assignment to variable err
> 
> External Email
> 
> ----------------------------------------------------------------------
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> variable err is assigned -ENOMEM followed by an error return path via label
> err_udev that does not access the variable and returns with the -ENOMEM error
> return code. The assignment to err is redundant and can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
>  drivers/scsi/qedi/qedi_main.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c index
> 69c5b5ee2169..2455d1448a7e 100644
> --- a/drivers/scsi/qedi/qedi_main.c
> +++ b/drivers/scsi/qedi/qedi_main.c
> @@ -276,10 +276,8 @@ static int qedi_alloc_uio_rings(struct qedi_ctx *qedi)
>  	}
> 
>  	udev = kzalloc(sizeof(*udev), GFP_KERNEL);
> -	if (!udev) {
> -		rc = -ENOMEM;
> +	if (!udev)
>  		goto err_udev;
> -	}
> 
>  	udev->uio_dev = -1;
> 
> --
> 2.30.2

Thanks,
Acked-by: Manish Rangankar <mrangankar@xxxxxxxxxxx>