Re: [PATCH v5 09/19] gpio: support ROHM BD71815 GPOs

From: Andy Shevchenko
Date: Tue Mar 30 2021 - 06:55:25 EST


On Tue, Mar 30, 2021 at 1:43 PM Matti Vaittinen
<matti.vaittinen@xxxxxxxxxxxxxxxxx> wrote:
> On Tue, 2021-03-30 at 13:11 +0300, Andy Shevchenko wrote:

...

> Andy, how fatal do you think these issues are? I did put these comments
> on my 'things to clean-up' list.
>
> If you don't see them as fatal, then I rather not resend whole series
> of 19 patches just for these. I am anyway going to rework the ROHM PMIC
> GPIO drivers which I have authored during the next couple of months for
> regmap_gpio usage. This series has most of the acks except for the
> regulator part - so I was about to suggest to Lee that perhaps he could
> apply other but regulator stuff to MFD so I could squeeze the recipient
> list and amount of patches in series.

I understand that. I'm not a maintainer, but my personal view is that
it can be fixed in follow ups.
The problem as usual here is that people often forget to cook / send
follow up. That's why lately I'm more insisting on changes to be done
as soon as possible.

--
With Best Regards,
Andy Shevchenko