Re: [PATCH v5 09/19] gpio: support ROHM BD71815 GPOs
From: Vaittinen, Matti
Date: Tue Mar 30 2021 - 08:07:21 EST
On Tue, 2021-03-30 at 13:11 +0300, Andy Shevchenko wrote:
> On Mon, Mar 29, 2021 at 3:58 PM Matti Vaittinen
> <matti.vaittinen@xxxxxxxxxxxxxxxxx> wrote:
> >
> > +struct bd71815_gpio {
> > + struct gpio_chip chip;
> > + struct device *dev;
>
> Wondering why you need this. Is it the same as chip.parent?
>
This is exactly the reason why I had the comments you objected in the
probe. dev is pointer to the platform device - which should be used for
prints and any potential devm stuff.
chip.parent is the MFD device which provides the regmap access and DT
node.
Best Regards
Matti Vaittinen